Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction support for signing and timed service - 2 #110

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

netmackan
Copy link
Collaborator

Cleanup of the commits from #76

Describe your changes

From @3keyroman:

There are use cases, when siging worker needs to be executed in transaction because it interacts with the database. Typically, when the keys are stored in the database, or some other information needs to be updated during signing execution.

This implementation introduces feature to turn on the transaction handling for other use cases then for key usage counter or archiving. Specifically for signing and timed services.

There is a new interface requiresTransaction implemented, which is false by default.

How has this been tested?

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

See also Contributing Guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants